Yedidyah Bar David has posted comments on this change. Change subject: bin: add the host to a specific cluster ......................................................................
Patch Set 12: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/25456/12/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 418: self.logger.debug('Adding the host to the cluster') Line 419: cluster_l = [c.get_name() for c in engine_api.clusters.list()] Line 420: cluster_name = default_cluster_name if default_cluster_name in \ Line 421: cluster_l else cluster_l[0] Line 422: cluster_name = self.dialog.queryString( Perhaps we want to allow override from the environment? Can probably be done in a separate patch Line 423: name='cluster_name', Line 424: note=_( Line 425: 'Enter the name of the cluster to which you want to add ' Line 426: 'the host (@VALUES@) [@DEFAULT@]: ' -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <mbour...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Meital bourvine <meitalbourv...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
