Gilad Chaplik has posted comments on this change. Change subject: engine: Adding a down event for HA Reservation ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/25949/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 87: Line 88: private final VdsFreeMemoryChecker noWaitingMemoryChecker = new VdsFreeMemoryChecker(new NonWaitingDelayer()); Line 89: private MigrationHandler migrationHandler; Line 90: Line 91: private Map<Guid, Boolean> clusterId2isHaReservationSafe = new HashMap<>(); declare as final Line 92: Line 93: private SchedulingManager() { Line 94: policyMap = new ConcurrentHashMap<Guid, ClusterPolicy>(); Line 95: policyUnits = new ConcurrentHashMap<Guid, PolicyUnitImpl>(); Line 802: AlertDirector.Alert(logable, AuditLogType.CLUSTER_ALERT_HA_RESERVATION); Line 803: log.infoFormat("Cluster: {0} fail to pass HA reservation check.", cluster.getName()); Line 804: } Line 805: Line 806: boolean oldStatus = can status/oldStatus have a clearer name? Line 807: clusterId2isHaReservationSafe.containsKey(cluster.getId()) ? clusterId2isHaReservationSafe.get(cluster.getId()) Line 808: : true; Line 809: Line 810: // Update the status map with the new status Line 815: AuditLogableBase logable = new AuditLogableBase(); Line 816: logable.setVdsGroupId(cluster.getId()); Line 817: logable.addCustomValue("ClusterName", cluster.getName()); Line 818: AlertDirector.Alert(logable, AuditLogType.CLUSTER_ALERT_HA_RESERVATION_DOWN); Line 819: log.infoFormat("Cluster: {0} pass HA reservation check.", cluster.getName()); afaik AlertDirector writes to log as well. if so remove the log write. Line 820: } Line 821: } Line 822: } Line 823: } http://gerrit.ovirt.org/#/c/25949/1/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 776: VM_CONSOLE_CONNECTED=User ${UserName} is connected to VM ${VmName}. Line 777: VM_CONSOLE_DISCONNECTED=User ${UserName} got disconnected from VM ${VmName}. Line 778: VDS_STATUS_CHANGE_FAILED_DUE_TO_STOP_SPM_FAILURE=Failed to change status of host '${VdsName}' due to a failure to stop the spm. Line 779: CLUSTER_ALERT_HA_RESERVATION=Cluster ${ClusterName} failed the HA Reservation check, HA VMs on host(s): ${Hosts} will fail to migrate in case of a failover, consider adding resources or shutting down unused VMs. Line 780: CLUSTER_ALERT_HA_RESERVATION_DOWN=Cluster ${ClusterName} passed the HA Reservation check. mismatch between key and value Line 781: PM_POLICY_UP_TO_MAINTENANCE=Host ${Host} is not currently needed, activating maintenance mode in preparation for shutdown. Line 782: PM_POLICY_MAINTENANCE_TO_DOWN=Host ${Host} is not currently needed, shutting down. Line 783: PM_POLICY_TO_UP=Reactivating host ${Host} according to the current power management policy. Line 784: USER_ADDED_AFFINITY_GROUP=Affinity Group ${affinityGroupName} was added. (User: ${UserName}) -- To view, visit http://gerrit.ovirt.org/25949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebc82d3cc190d439b77e45e7e6b3eb7451f71c3c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
