Simone Tiraboschi has posted comments on this change. Change subject: Refactor to improve code readability ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26311/1/src/__main__.py File src/__main__.py: Line 1131: # meta file Line 1132: if not self.__rewrite_ovf(n_id_d, Line 1133: old_image_id, Line 1134: ovf_file, Line 1135: source_dir, tree): > please use indentation like: Done Line 1136: return False Line 1137: Line 1138: # At this point we should have a mapping of old image_ids to new Line 1139: # ids. We need to do a few things... -- To view, visit http://gerrit.ovirt.org/26311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e9fbdacaed5ee6bc17bee50abc36a2f49dd496 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
