Daniel Erez has uploaded a new change for review. Change subject: webadmin: TaskListModel - potential exception on race ......................................................................
webadmin: TaskListModel - potential exception on race Verified 'detailedTaskMap.get(id)' is not null before accessing its members (as there's a race condition in updating the value). Change-Id: If5510ce522ffe097d592cfb9e689d3d27facf84f Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/26316/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java index cd88279..45d1f72 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java @@ -137,7 +137,7 @@ } else { id = task.getId().toString(); } - boolean hadDetails = detailedTaskMap.containsKey(id); + boolean hadDetails = detailedTaskMap.containsKey(id) && detailedTaskMap.get(id) != null; if (hadDetails && task.getLastUpdateTime().getTime() - detailedTaskMap.get(id).getLastUpdateTime().getTime() < 100) { -- To view, visit http://gerrit.ovirt.org/26316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If5510ce522ffe097d592cfb9e689d3d27facf84f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
