Daniel Erez has uploaded a new change for review. Change subject: core: added GetAllSnapshotImagesByStorageDomainIdQuery ......................................................................
core: added GetAllSnapshotImagesByStorageDomainIdQuery Added GetAllSnapshotImagesByStorageDomainIdQuery for fetching all volumes (non-active) according to a specific storage domain. Change-Id: I389579e4120cb33edca594caa762a8bad63362b7 Signed-off-by: Daniel Erez <[email protected]> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSnapshotImagesByStorageDomainIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/26323/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSnapshotImagesByStorageDomainIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSnapshotImagesByStorageDomainIdQuery.java new file mode 100644 index 0000000..893bfab --- /dev/null +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSnapshotImagesByStorageDomainIdQuery.java @@ -0,0 +1,49 @@ +package org.ovirt.engine.core.bll; + +import java.util.List; + +import org.apache.commons.collections.CollectionUtils; +import org.apache.commons.collections.Predicate; +import org.ovirt.engine.core.common.businessentities.DiskImage; +import org.ovirt.engine.core.common.businessentities.Snapshot; +import org.ovirt.engine.core.common.queries.IdQueryParameters; + +public class GetAllSnapshotImagesByStorageDomainIdQuery<P extends IdQueryParameters> extends QueriesCommandBase<P> { + + public GetAllSnapshotImagesByStorageDomainIdQuery(P parameters) { + super(parameters); + } + + @Override + protected void executeQueryCommand() { + List<DiskImage> diskImages = + getDbFacade().getDiskImageDao().getAllSnapshotsForStorageDomain(getParameters().getId()); + + // Filter out active volumes + CollectionUtils.filter(diskImages, new Predicate() { + @Override + public boolean evaluate(Object diskImage) { + return !((DiskImage) diskImage).getActive(); + } + }); + + // Retrieving snapshots objects for setting description + List<Snapshot> snapshots = + getDbFacade().getSnapshotDao().getAllByStorageDomain(getParameters().getId()); + + for (final DiskImage diskImage : diskImages) { + Snapshot snapshot = (Snapshot) CollectionUtils.find(snapshots, new Predicate() { + @Override + public boolean evaluate(Object snapshot) { + return diskImage.getVmSnapshotId().equals(((Snapshot) snapshot).getId()); + } + }); + + if (snapshot != null) { + diskImage.setVmSnapshotDescription(snapshot.getDescription()); + } + } + + getQueryReturnValue().setReturnValue(diskImages); + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 3a42d45..81ca410 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -119,6 +119,7 @@ GetAllAttachableDisks(VdcQueryAuthType.User), GetAllDisksByStorageDomainId, GetAllDisks(VdcQueryAuthType.User), + GetAllSnapshotImagesByStorageDomainId, GetUnregisteredDisks, GetUnregisteredDisk, GetDiskByDiskId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/26323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I389579e4120cb33edca594caa762a8bad63362b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
