Maor Lipchuk has uploaded a new change for review.
Change subject: core: ISO Storage Domain can be detached for suspended VM.
......................................................................
core: ISO Storage Domain can be detached for suspended VM.
Since the VM process is not running when the VM is suspended, we should
allow the user to detach the ISO Storage Domain, even if the VM is
suspended.
Change-Id: I3d6c75fccada58d9a537c94040b0eb86b3332e3f
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/26309/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
index f750b85..319ae2a 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
@@ -156,7 +156,8 @@
List<String> vmNames = new LinkedList<>();
for (VmStatic vmStatic : vms) {
VmDynamic vmDynamic = getVmDynamicDAO().get(vmStatic.getId());
- if (vmDynamic.getStatus() != VMStatus.Down &&
!StringUtils.isEmpty(vmDynamic.getCurrentCd())) {
+ if (vmDynamic.getStatus() != VMStatus.Down &&
vmDynamic.getStatus() != VMStatus.Suspended
+ && !StringUtils.isEmpty(vmDynamic.getCurrentCd())) {
vmNames.add(vmStatic.getName());
}
}
--
To view, visit http://gerrit.ovirt.org/26309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d6c75fccada58d9a537c94040b0eb86b3332e3f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
