Juan Hernandez has posted comments on this change. Change subject: core: Introduce boot time field in VDS ......................................................................
Patch Set 7: Code-Review+1 (2 comments) I agree with changing the name to "boot.time", other than that the RESTAPI part looks good. http://gerrit.ovirt.org/#/c/25880/7/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostStatisticalQuery.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostStatisticalQuery.java: Line 25: private final static Statistic CPU_USER = create("cpu.current.user", "User CPU usage", GAUGE, PERCENT, DECIMAL); Line 26: private final static Statistic CPU_SYS = create("cpu.current.system", "System CPU usage", GAUGE, PERCENT, DECIMAL); Line 27: private final static Statistic CPU_IDLE = create("cpu.current.idle", "Idle CPU usage", GAUGE, PERCENT, DECIMAL); Line 28: private final static Statistic CPU_LOAD = create("cpu.load.avg.5m", "CPU 5 minute load average", GAUGE, PERCENT, DECIMAL); Line 29: private final static Statistic BOOT_TIME = create("time.boot", "Boot time of the machine", GAUGE, NONE, INTEGER); > boot.time instead of time.boot? Makes sense. Dima, please change the name as Roy suggests. Line 30: Line 31: protected HostStatisticalQuery(Host parent) { Line 32: this(null, parent); Line 33: } http://gerrit.ovirt.org/#/c/25880/7/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java: Line 594: verifyStatistics(statistics, Line 595: new String[] {"memory.total", "memory.used", "memory.free", "memory.shared", Line 596: "memory.buffers", "memory.cached", "swap.total", "swap.free", "swap.used", Line 597: "swap.cached", "ksm.cpu.current", "cpu.current.user", "cpu.current.system", Line 598: "cpu.current.idle", "cpu.load.avg.5m", "time.boot"}, Remember to change to "boot.time" here as well. Line 599: new BigDecimal[] {asDec(5120*Mb), asDec(1024*Mb), asDec(4096*Mb), asDec(38*Mb), asDec(0), asDec(0), asDec(30*Mb), Line 600: asDec(25*Mb), asDec(5*Mb), asDec(0), asDec(40), asDec(45), asDec(50), asDec(55), new BigDecimal(0.0060, new MathContext(2)), asDec(0)}); Line 601: Statistic adopted = query.adopt(new Statistic()); Line 602: assertTrue(adopted.isSetHost()); -- To view, visit http://gerrit.ovirt.org/25880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec679a4ce5ddfbc1735db380feab69eb3798ae6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
