Tomas Jelinek has posted comments on this change. Change subject: frontend: Proper VM SystemTab Validation ......................................................................
Patch Set 1: (1 comment) just a small comment, in general seems good http://gerrit.ovirt.org/#/c/26268/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ByteSizeValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ByteSizeValidation.java: Line 5: { Line 6: public ByteSizeValidation() Line 7: { Line 8: setExpression("^\\d+\\s*(m|mb|g|gb|t|tb){0,1}\\s*$"); //$NON-NLS-1$ Line 9: setMessage("TODO:"); //$NON-NLS-1$ well, as already touching this code it would be good to put a bit better message :) Line 10: } -- To view, visit http://gerrit.ovirt.org/26268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
