Doron Fediuck has posted comments on this change. Change subject: core: Return 1 from StoreUtils on error ......................................................................
Patch Set 1: (1 inline comment) Juan, please see inline- I prefer a single exit point, especially when it terminates the code execution. .................................................... File backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java Line 197: System.exit(1); Juan, I prefer a single exit point on multiple points. Do you mind defining Integer exitCode = 0 in the method beginning, and a single System.exit(exitCode) at the method's end? Then you simply need to set this value once in the catch block to 1. -- To view, visit http://gerrit.ovirt.org/4848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc6d3c0f26128bfc2418bbb4da85440909003b59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
