Liran Zelkha has uploaded a new change for review.

Change subject: core: Revert Delete jobs that their steps have no async-tasks
......................................................................

core: Revert Delete jobs that their steps have no async-tasks

Patch 22474 and 26056 added an ability to remove jobs that have
no steps an no async-steps. This caused long running jobs to be
removed while running, causing insert errors and removing them
from customer use.

This patch removes that functionality. If jobs fail, they should
be marked as such. And if they are not, it is the job writer
responsibility to fix this behavior as a bug.

Change-Id: Ief49517c37188839572cd4e95a25b2f921f4b5e1
Bug-Url: https://bugzilla.redhat.com/1076246
Signed-off-by: lzel...@redhat.com <lzel...@redhat.com>
---
M packaging/dbscripts/job_sp.sql
1 file changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/26291/1

diff --git a/packaging/dbscripts/job_sp.sql b/packaging/dbscripts/job_sp.sql
index 5b5427d..3aa675b 100644
--- a/packaging/dbscripts/job_sp.sql
+++ b/packaging/dbscripts/job_sp.sql
@@ -484,17 +484,6 @@
     AND    status = 'FINISHED')
     OR    (end_time < v_failed_end_time
     AND    status IN ('FAILED', 'ABORTED', 'UNKNOWN'))));
-
-    DELETE FROM job
-    WHERE job_id IN
-        (SELECT job_id
-         FROM job
-         WHERE NOT is_external
-               AND NOT EXISTS
-                (SELECT step.step_id
-                 FROM step, async_tasks
-                 WHERE step.job_id = job_id AND async_tasks.step_id = 
step.step_id));
-
 END; $procedure$
 LANGUAGE plpgsql;
 


-- 
To view, visit http://gerrit.ovirt.org/26291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief49517c37188839572cd4e95a25b2f921f4b5e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to