Yedidyah Bar David has posted comments on this change. Change subject: Clean the code to pass pep8 checks ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26176/3/src/__main__.py File src/__main__.py: Line 919: logging.error("Unable rewrite metafile. Message: %s" % ex) Line 920: return False Line 921: return True Line 922: Line 923: def __update_xml_item_puuid(self, ovf_file, tree, image_id_dict): > Basically I agree with you, it's not required by pep8 to broke the code int So you can do it in a different change _before_ the pep8 one... Line 924: """ Line 925: This method will update the Content/Section/Item/Parent element Line 926: UUIDs with correct replacement for images with snapshots. Line 927: """ -- To view, visit http://gerrit.ovirt.org/26176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9f7416f0f81f0913d3c0145cd3c42e05377d71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
