Eli Mesika has uploaded a new change for review. Change subject: core: skipping DOWN hosts in PM proxy selection ......................................................................
core: skipping DOWN hosts in PM proxy selection Hosts with DOWN state were not filtered out when no UP Host available and we are looking for Hosts in other statuses. This patch addresses this issue and filter out all Hosts with DOWN status. Change-Id: Ie12002cbdbf025d5e53b2283dee7b373dac2a0a4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073896 Signed-off-by: Eli Mesika <emes...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/26282/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java index 2ec8cd3..4ccf704 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java @@ -275,7 +275,10 @@ private boolean isHostNetworkUnreacable(VDS vds) { VdsDynamic vdsDynamic = vds.getDynamicData(); - return ((vdsDynamic.getStatus() == VDSStatus.Reboot) || (vdsDynamic.getStatus() == VDSStatus.NonOperational && vdsDynamic.getNonOperationalReason() == NonOperationalReason.NETWORK_UNREACHABLE)); + return (vdsDynamic.getStatus() == VDSStatus.Down + || vdsDynamic.getStatus() == VDSStatus.Reboot + || (vdsDynamic.getStatus() == VDSStatus.NonOperational + && vdsDynamic.getNonOperationalReason() == NonOperationalReason.NETWORK_UNREACHABLE)); } private VDS getFenceProxy(final boolean onlyUpHost, final boolean filterSelf, final PMProxyOptions proxyOptions) { -- To view, visit http://gerrit.ovirt.org/26282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie12002cbdbf025d5e53b2283dee7b373dac2a0a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
