Shirly Radco has posted comments on this change. Change subject: reports: br16 report - added comments to queries ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/25072/6/packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data: Line 121: ')' Line 122: END, Line 123: v3_4_statistics_vms_resources_usage_$P!{table_name}.history_datetime Line 124: ) Line 125: a > Add 'as' a move up one to be after ( Done Line 126: RIGHT OUTER JOIN calendar b Line 127: ON ( Line 128: time = $P!{calendar_column} Line 129: ) Line 122: END, Line 123: v3_4_statistics_vms_resources_usage_$P!{table_name}.history_datetime Line 124: ) Line 125: a Line 126: RIGHT OUTER JOIN calendar b > this should be indented by one tab spaces Done Line 127: ON ( Line 128: time = $P!{calendar_column} Line 129: ) Line 130: WHERE -- To view, visit http://gerrit.ovirt.org/25072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84448da418837c6aae3a0a79d42ab072d0fd5c01 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
