Allon Mureinik has posted comments on this change. Change subject: core: send domains map on connectStoragePool ......................................................................
Patch Set 9: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/22712/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 50: canChooseCurrentMasterAsNewMaster = parameters.isCanChooseCurrentMasterAsNewMaster(); Line 51: } Line 52: Line 53: private boolean checkIsDomainLocked(StoragePoolIsoMap domainMap) { Line 54: if (StorageDomainStatus.Locked == domainMap.getStatus()) { wouldn't we want to check "detaching" too? Line 55: addInvalidSDStatusMessage(StorageDomainStatus.Locked); Line 56: return true; Line 57: } Line 58: -- To view, visit http://gerrit.ovirt.org/22712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
