Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: Persist advanced/basic mode per dialog type ......................................................................
Patch Set 2: > # It seems that sometimes the storage key comes from a method and other times > it is just some string from somewhere, is there any rhyme or reasoning to it. > Can we maybe in a base class always call some method, and each sub class just > override that method to provide the key value? It is only a key. You need to set in into the model before calling setWindow(). The way you create the key is mostly just provide it as a string. Only in one place it is a method which returns it to give an opportunity to return a different from a child. # You are passing LocalStorage to all kinds of presenters, due to LocalStorage being browser specific you now have essentially made it impossible to unit test the presenters. Would it be possible to make a LocalStorage interface and pass that into the presenters, then we can mock the interface and still test the presenters. This is something we probably should have done a while ago. Right. Done it http://gerrit.ovirt.org/#/c/26238/ -- To view, visit http://gerrit.ovirt.org/26170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I786daf31eb5cf713bf5b7afe1210d2655ef7bd4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
