Allon Mureinik has posted comments on this change. Change subject: core: Add javadoc comments to AddVM commands ......................................................................
Patch Set 1: (6 comments) http://gerrit.ovirt.org/#/c/26160/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-27 17:05:51 +0200 Line 6: Line 7: core: Add javadoc comments to AddVM commands Line 8: Line 9: Added short comments to distinguish between the AddVmCommand Class and s/Class/class/ Line 10: its descendants. Line 11: Line 12: Change-Id: Ie33cf2573caeb87e476048f48f3c90871f40446f http://gerrit.ovirt.org/#/c/26160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java: Line 14: import org.ovirt.engine.core.common.utils.Pair; Line 15: Line 16: /** Line 17: * This class adds a thinly provisioned VM based on disks list or over a template. Line 18: * The Vm is created as a member in a VM pool. s/Vm/VM/ Line 19: * Line 20: * @param <T> Line 21: */ Line 22: @InternalCommandAttribute Line 16: /** Line 17: * This class adds a thinly provisioned VM based on disks list or over a template. Line 18: * The Vm is created as a member in a VM pool. Line 19: * Line 20: * @param <T> Either describe it, or remove it. Currently, this doesn't add any info. Line 21: */ Line 22: @InternalCommandAttribute Line 23: @NonTransactiveCommandAttribute Line 24: public class AddVmAndAttachToPoolCommand<T extends AddVmAndAttachToPoolParameters> extends AddVmCommand<T> { http://gerrit.ovirt.org/#/c/26160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 85: Line 86: /** Line 87: * This class adds a thinly provisioned VM over a template Line 88: * Line 89: * @param <T> Either describe it, or remove it. Currently, this doesn't add any info. Line 90: */ Line 91: @DisableInPrepareMode Line 92: @LockIdNameAttribute(isReleaseAtEndOfExecute = false) Line 93: @NonTransactiveCommandAttribute http://gerrit.ovirt.org/#/c/26160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java: Line 26: Line 27: /** Line 28: * This class adds a thinly provisioned VM based on disks list. Line 29: * Line 30: * @param <T> Either describe it, or remove it. Currently, this doesn't add any info. Line 31: */ Line 32: @DisableInPrepareMode Line 33: @LockIdNameAttribute Line 34: @NonTransactiveCommandAttribute http://gerrit.ovirt.org/#/c/26160/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java: Line 22: /** Line 23: * This class adds a cloned VM from a template (Deep disk copy) Line 24: * Line 25: * @param <T> Line 26: */ Either describe it, or remove it. Currently, this doesn't add any info. Line 27: @LockIdNameAttribute(isReleaseAtEndOfExecute = false) Line 28: public class AddVmFromTemplateCommand<T extends AddVmFromTemplateParameters> extends AddVmCommand<T> { Line 29: Line 30: public AddVmFromTemplateCommand(T parameters) { -- To view, visit http://gerrit.ovirt.org/26160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33cf2573caeb87e476048f48f3c90871f40446f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
