Omer Frenkel has posted comments on this change. Change subject: core: make ClearNonResponsiveVdsVms non-transactive ......................................................................
Patch Set 2: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/26153/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-27 11:12:32 -0400 Line 6: Line 7: core: make ClearNonResponsiveVdsVms non-transactive Line 8: Line 9: ClearNonResponsiveVdsVmsCommand basically to the following things: to->do Line 10: 1. Change all the VMs that ran on the host to DOWN Line 11: 2. Update the VDS attributes as if no VM is running on the host Line 12: 3. Run HA VMs that ran on the host Line 13: Line 26: The only problematic case of changing the status of the VMs outside of a Line 27: transaction scope will be if the host was powered off and we didn't Line 28: reach stage #3 (run the HA VMs) after doing stage #1 (this is very Line 29: unlikely to happen though) - The VMs will be DOWN and their runningOnVds Line 30: field will be black so VURTI won't try to rerun them when the host will black->blank Line 31: go up. The good side is that the user will be able to run them manually Line 32: if the host is not going to restart (as opposed to keep them in UNKNOWN Line 33: state). Line 34: -- To view, visit http://gerrit.ovirt.org/26153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8728e56f21ff6dcf6e103b1d450eecfaa36e809 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
