Yaniv Dary has posted comments on this change. Change subject: build: post ovirt-engine-dwh-3.4.0-2 ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/26209/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-30 11:20:41 +0700 Line 4: Commit: Yaniv Dary <yd...@redhat.com> Line 5: CommitDate: 2014-03-30 11:21:05 +0700 Line 6: Line 7: build: post ovirt-engine-dwh-3.4.0-2 > please do not use downstream terms in upstream, it should be: We had two release since original GA was turned to second RC. Line 8: Line 9: Change-Id: I82ec5bc0f9fb819a3a159f92e721e7b169b5ebcd http://gerrit.ovirt.org/#/c/26209/1/etl_export/ovirt_engine_dwh/minimalversioncheck_3_4/contexts/Default.properties File etl_export/ovirt_engine_dwh/minimalversioncheck_3_4/contexts/Default.properties: Line 2: #Sun Jun 17 18:23:25 IDT 2012 Line 3: ovirtEngineHistoryDbDriverClass=org.postgresql.Driver Line 4: ovirtEngineHistoryMinimalETL=null Line 5: ovirtEngineHistoryDbUser=postgres Line 6: etlVersion=3.4.1 > can't we read this dynamically from file we generate? What file contains package version? This is a default value loaded is no override is provided. Line 7: ovirtMinimalETL=null Line 8: ovirtEngineHistoryDbJdbcConnection=jdbc\:postgresql\://localhost\:5432/ovirt_engine_history?stringtype\=unspecified Line 9: ovirtEngineDbPassword= Line 10: ovirtEngineDbJdbcConnection=jdbc\:postgresql\://localhost\:5432/engine?stringtype\=unspecified http://gerrit.ovirt.org/#/c/26209/1/ovirt-engine-dwh.spec.in File ovirt-engine-dwh.spec.in: Line 242: %{_datadir}/ovirt-engine/setup/plugins/*/ovirt-engine-dwh/ Line 243: Line 244: %changelog Line 245: * Sun Mar 30 2014 Yaniv Dary <yd...@redhat.com> - 3.4.1 Line 246: Changed version to 3.4.1 post 3.4.0 GA. > this should be added only when you release 3.4.1 Same reply as in patch 26208 Line 247: Line 248: * Mon Mar 24 2014 Yaniv Dary <yd...@redhat.com> - 3.4.0-2 Line 249: Fixed issues: Line 250: - move connect to database library (#1067058) http://gerrit.ovirt.org/#/c/26209/1/tos_project/context/connectionJDBC_3.4.item File tos_project/context/connectionJDBC_3.4.item: Line 13: <contextParameter comment="Enter the amout of hour to keep Hourly level records." name="hoursToKeepHourly" prompt="How many hours to keep of hourly data?" promptNeeded="true" type="id_Integer" value="1440"/> Line 14: <contextParameter comment="Enter the amout of hour to keep Daily level records." name="hoursToKeepDaily" prompt="How many hours to keep of daily data?" promptNeeded="true" type="id_Integer" value="43800"/> Line 15: <contextParameter comment="Enter the amout of hour to keep Samples level records." name="hoursToKeepSamples" prompt="How many hours to keep of samples data?" promptNeeded="true" type="id_Integer" value="24"/> Line 16: <contextParameter comment="End run time." name="endTime" prompt="endTime?" promptNeeded="false" type="id_Date" value=""/> Line 17: <contextParameter comment="" name="etlVersion" prompt="etlVersion?" promptNeeded="false" type="id_String" value="3.4.1"/> > please consider this to be read from external properties file or system pro It is read from there as well. but this is for a example when this is not provided for example devel testing. Line 18: <contextParameter comment="Enter the time to run the delete job. Can only run on round hour 24 hours clock." name="runDeleteTime" prompt="runDeleteTime?" promptNeeded="true" type="id_Integer" value="3"/> Line 19: <contextParameter comment="" name="lastErrorSent" prompt="lastErrorSent?" promptNeeded="true" type="id_Date" value="yyyy-MM-dd HH:mm:ss.SSSSSS;2011-07-03 12:46:47.000000"/> Line 20: <contextParameter comment="Enter the amout of to wait between sending error events to audit log" name="timeBetweenErrorEvents" prompt="timeBetweenErrorEvents?" promptNeeded="true" type="id_Long" value="300000"/> Line 21: <contextParameter comment="" name="timesFailed" prompt="timesFailed?" promptNeeded="false" type="id_Integer" value="0"/> -- To view, visit http://gerrit.ovirt.org/26209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82ec5bc0f9fb819a3a159f92e721e7b169b5ebcd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
