Alon Bar-Lev has posted comments on this change. Change subject: packaging: added strandard log rotate config file ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/26210/1/ovirt-engine-reports.spec.in File ovirt-engine-reports.spec.in: Line 110: rm -f /var/lib/ovirt-engine/reports.xml Line 111: fi Line 112: Line 113: %files Line 114: %config(noreplace) %{_sysconfdir}/logrotate.d/jasperserver > This is the way you did this in dwh.. Is that by mistake? hmmm.... it is... ok, let's leave this as is. Line 115: %dir %attr(-, %{engine_user}, %{engine_group}) %{_localstatedir}/lib/%{reports_name} Line 116: %dir %attr(-, %{engine_user}, %{engine_group}) %{_localstatedir}/log/%{reports_name} Line 117: %{_localstatedir}/lib/ovirt-engine-reports/backups/ Line 118: %{_sysconfdir}/ovirt-engine/engine.conf.d/20-ovirt-engine-reports.conf http://gerrit.ovirt.org/#/c/26210/1/packaging/sys-etc/logrotate.d/jasperserver.in File packaging/sys-etc/logrotate.d/jasperserver.in: > We do present it as jasper I believe. what do you mean? we should have no conflict with other applications, all should go into ovirt- prefix. in this case it is ovirt-engine-reports to hold the settings of all loggers of this packages. Line 1: @PKG_LOG_DIR@/jasperserver.log { Line 2: size 10M Line 3: missingok Line 4: copytruncate Line 3: missingok Line 4: copytruncate Line 5: rotate 5 Line 6: compress Line 7: } > It's not in use. but it will be created... right? if not, please patch it to /dev/null as nothing should be created at WEB-INF -- To view, visit http://gerrit.ovirt.org/26210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78b204a139de079ca9eb70a1341ec0045c064ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
