Daniel Erez has posted comments on this change. Change subject: frontend: widgets needed to support instance types ......................................................................
Patch Set 14: (4 comments) http://gerrit.ovirt.org/#/c/25023/14/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelDetachableWidgetWithInfo.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelDetachableWidgetWithInfo.java: Line 30: return ((HasEnabled) contentWidget).isEnabled(); Line 31: } Line 32: Line 33: public EntityModelDetachableWidget getContentWidget() { Line 34: // it is safe since I it is created in this class and there is no way to create it from outside * redundant 'I' in the comment * not sure the code isn't self explanatory any way... Line 35: return (EntityModelDetachableWidget) contentWidget; Line 36: } Line 37: http://gerrit.ovirt.org/#/c/25023/14/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BaseEntityModelDetachableWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BaseEntityModelDetachableWidget.java: Line 32: this.style = style; Line 33: Line 34: setAttached(true); Line 35: Line 36: // by default it is a regular widget - needs to be made detachable explicitly why is it done explicitly? Line 37: setDetachableIconVisible(false); Line 38: } Line 39: Line 40: @Override http://gerrit.ovirt.org/#/c/25023/14/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.java: Line 50: if (attachedImageAlign == Align.LEFT) { Line 51: contentWidgetContainer.getElement().getStyle().setFloat(Float.RIGHT); Line 52: } else { Line 53: contentWidgetContainer.getElement().getStyle().setFloat(Float.LEFT); Line 54: contentWidgetContainer.getElement().getStyle().setWidth(230, com.google.gwt.dom.client.Style.Unit.PX); * I guess '230' value is the width of WidgetWthLabel? If so, it's probably a good time to extract and reuse this value... * Probably should add 'com.google.gwt.dom.client.Style.Unit' to imports list. Line 55: contentWrapper.removeStyleName(style.contentWrapper()); Line 56: contentWrapper.addStyleName(style.contentWrapperImageOnRight()); Line 57: } Line 58: http://gerrit.ovirt.org/#/c/25023/14/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.ui.xml: Line 39: width: 200px; Line 40: } Line 41: Line 42: .contentWidgetContainer { Line 43: /*width: 230px;*/ can be removed? Line 44: } Line 45: Line 46: </ui:style> Line 47: -- To view, visit http://gerrit.ovirt.org/25023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fcc24e753fad19273ba3b16fba0b8be70bc4395 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
