Tomas Jelinek has uploaded a new change for review.

Change subject: userportal,webadmin: Remove redundant scroll bar in VM general 
tab
......................................................................

userportal,webadmin: Remove redundant scroll bar in VM general tab

The ProfilesInstanceTypeEditor had the vertical size hardcoded and was wrapped
by a ScrollPanel. This caused the redundant scroll bar in the VM general tab to
appear.

Fixed by removing the ScrollPanel since in all other tabs in the VM dialog the
scrolling is handled by the dialog itself - this change makes the behavior
consistent with the rest of the tabs.

Change-Id: I735fe5fb280f76c6ec771389879433cc9c42ff91
Bug-Url: https://bugzilla.redhat.com/1047883
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/26169/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
index e6ca471..3fdef84 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
@@ -27,9 +27,7 @@
 
        <g:FlowPanel addStyleNames="{style.mainPanel}" >
                <g:Label ui:field="headerLabel" 
addStyleNames="{style.headerLabel}" />
-               <g:ScrollPanel height="190px">
-                       <g:FlowPanel ui:field="contentPanel" />
-               </g:ScrollPanel>
+               <g:FlowPanel ui:field="contentPanel" />
        </g:FlowPanel>
 
 </ui:UiBinder>


-- 
To view, visit http://gerrit.ovirt.org/26169
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I735fe5fb280f76c6ec771389879433cc9c42ff91
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to