Juan Hernandez has posted comments on this change.
Change subject: restapi: Enable support for Vm Boot menu
......................................................................
Patch Set 1:
If I understand correctly the bug, what we want to do here is to provide some
parameters to the BIOS of the VM, not to the operating system. So placing this
inside "os" is a bit misleading. We should probably add a new element to
represent those parameters, as we may want to add more in the future, the menu
timeout, for example. What about something like this?
<vm>
<bios>
<boot_menu>
<enabled>true|false</enabled>
</boot_menu>
</bios>
</vm>
This gives us room for adding more elements in the future, for example:
<vm>
<bios>
<boot_menu>
<enabled>true|false</enabled>
<timeout>10</timeout>
</boot_timeout>
</bios>
</vm>
I'm not 100% sure about the name of this, maybe BIOS is not the right name, as
it can also be EFI, or OpenFirmware. Maybe a more generic name is more
appropiate, for example "boot_rom". Gustavo, Lenoardo, Vitor, ho does this look
from the PPC point of view?
--
To view, visit http://gerrit.ovirt.org/26128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I926aaf58da72494f2e1710aec8530fe4794c2fe4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
