Frank Kobzik has uploaded a new change for review.
Change subject: userportal: Check connect availability on doubleclick
......................................................................
userportal: Check connect availability on doubleclick
This small patch adds checking whether user is allowed to connect to
console on doubleclick. (e.g. previously, when user doubleclicked vm
annoying dialog explaining that console isn't available would be
displayed).
Change-Id: I851b93eb8c68713be3c9738da551b59841623aa9
Signed-off-by: Frantisek Kobzik <fkob...@redhat.com>
---
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/26120/1
diff --git
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
index ee282ee..9195902 100644
---
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
+++
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
@@ -244,7 +244,7 @@
@Override
public void onDoubleClick(DoubleClickEvent event) {
try {
- if (!model.isPool()) {
+ if (model.getVmConsoles().canConnectToConsole()) {
model.getVmConsoles().connect();
}
} catch (VmConsoles.ConsoleConnectException e) {
--
To view, visit http://gerrit.ovirt.org/26120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I851b93eb8c68713be3c9738da551b59841623aa9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
