Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: io.StringIO needs unicode ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26118/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py: Line 62: def _parse_legacy_conf(self, filename): Line 63: config = configparser.ConfigParser() Line 64: config.optionxform = str Line 65: with open(filename) as f: Line 66: config.readfp(io.StringIO(u'[default]' + f.read())) at least one more issue that is fixed in python3. Line 67: return dict(config.items('default')) Line 68: Line 69: @plugin.event( Line 70: stage=plugin.Stages.STAGE_SETUP, -- To view, visit http://gerrit.ovirt.org/26118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5622a9fde642330277acf67e56784395daa7d7b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
