Eli Mesika has posted comments on this change.
Change subject: core: adding alias to vm_device
......................................................................
Patch Set 1: (21 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 299: "");
should be encapsulated in addManagedDevice since it is the same empty string
value for all calls
Line 326: "");
please remove alias setting (should be encapsulated in addManagedDevice
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 512: "");
please remove alias setting (should be encapsulated in addManagedDevice
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 313: "");
please remove alias setting (should be encapsulated in addManagedDevice
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 122: "");
please remove alias setting (should be encapsulated in addManagedDevice
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 121: addManagedDevice(new
VmDeviceId(Guid.NewGuid(),dstId) , VmDeviceType.DISK, VmDeviceType.CDROM,
specParams, true, true, "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 174: "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 199: return addManagedDevice(id, VmDeviceType.INTERFACE,
VmDeviceType.BRIDGE, null, plugged, false, "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 217: String alias) {
here you should omit the alias parameter
Line 228: alias);
change alias to "" since all the calls use this value , then alias handling is
encapsulated in this method
Line 346: "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 446: "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 492: "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 550: "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 571: "");
please remove alias setting (should be encapsulated in addManagedDevice
Line 642: "");
please remove alias setting (should be encapsulated in addManagedDevice
....................................................
File backend/manager/modules/dal/src/test/resources/fixtures.xml
Line 3056: <value>false</value>
alias should be added here as well
Line 3068: <value>false</value>
alias should be added here as well
Line 3081: <value>false</value>
alias should be added here as well
Line 3106: <value>false</value>
alias should be added here as well
Line 3118: <value>false</value>
alias should be added here as well
--
To view, visit http://gerrit.ovirt.org/4784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d543dbb96b002defbe2b85c88a4f24fab8e5f04
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
