Yaniv Dary has posted comments on this change.

Change subject: reports: br6 report - added comments to queries
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/25227/7/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/cluster_quality_of_service_hosts_br6_jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/cluster_quality_of_service_hosts_br6_jrxml.data:

Line 85:                     THEN minutes_in_status
Line 86:             ELSE 0
Line 87:         END
Line 88:     )
Line 89:     AS mem_above
please indent this to the sum. also the END and ELSE.
Line 90:     FROM (
Line 91:         SELECT DISTINCT
Line 92:             v3_4_configuration_history_hosts.host_id,
Line 93:             history_datetime,


http://gerrit.ovirt.org/#/c/25227/7/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/full+details+br13.jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/full
 details br13.jrxml.data:

Line 116:             THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 
month' - interval '1 day' AS date)
Line 117:         WHEN $P{P_Period} = 2
Line 118:             THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '3 
month' - interval '1 day' AS date)
Line 119:         WHEN $P{P_Period} = 3
Line 120:             THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 
year' - interval '1 day' AS date)
dorp lines
Line 121:     END AS end_date,
Line 122:     (
Line 123:         SELECT DISTINCT
Line 124:             COALESCE (


-- 
To view, visit http://gerrit.ovirt.org/25227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c7f8127ad7fca24446776427b2eb6bce843b1cb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to