Omer Frenkel has posted comments on this change. Change subject: core: Added user queries to retrieve instance types and images ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24726/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java: Line 148: public void testGetAllWithPermissionsForUnpriviligedUser() { Line 149: List<VmTemplate> result = dao.getAll(UNPRIVILEGED_USER_ID, true, VmEntityType.TEMPLATE); Line 150: assertNotNull(result); Line 151: assertTrue(result.isEmpty()); Line 152: } maybe add a test for getting instance types as well? Line 153: Line 154: /** Line 155: * Ensures the right set of templates are returned. Line 156: */ -- To view, visit http://gerrit.ovirt.org/24726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfddb6e292010c33fadcaf89bce2a5fb51ff87a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
