Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: support compressed backup/restore ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/26073/3/packaging/setup/ovirt_engine_setup/database.py File packaging/setup/ovirt_engine_setup/database.py: Line 650: def backup( Line 651: self, Line 652: dir, Line 653: prefix, Line 654: compr='bzip2', > compr is not clear, usually filter is better. "user chooses" - you want to ask them? environment? Or "we choose" (but in setup and not here)? Line 655: compr_suffix='.bz2', Line 656: ): Line 657: fd, backupFile = tempfile.mkstemp( Line 658: prefix='%s-%s.' % ( Line 701: stdin=dump_proc.stdout, Line 702: stdout=output_file, Line 703: stderr=subprocess.PIPE, Line 704: close_fds=True, Line 705: ) > if you do this using generic n elements we can consider adding this to otop For testing this I ran 'yes test1234 | head -100000 | bzip2'. If I ran Popen.communicate on the 'yes' process, it would never end. python just keeps running it and collecting the output in a buffer and causing the machine to thrash. Tried this with several bufsize values, all were the same. Tried also before and after calling communicate on the other processes, no change. 'strace' never showed that 'yes' got a EPIPE or anything. Do we want to consider such cases? stderrs - just collect and return all of them in a list (perhaps optionally). Same for RCs - once we decide about the above paragraph. Line 706: dump_stdout, dump_stderr = dump_proc.communicate() Line 707: compr_stdout, compr_stderr = compr_proc.communicate() Line 708: dump_rc = dump_proc.returncode Line 709: compr_rc = compr_proc.returncode -- To view, visit http://gerrit.ovirt.org/26073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I684f025c9c1d29c701068ba967be5a2115c7a6fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
