Roy Golan has posted comments on this change.
Change subject: tools: Add flag only-reloadable to engine-config
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java
Line 69: } else {
formatting
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java
Line 113: public void setOnlyReloadable(String parseOptionKey) {
just a matter of taste, maybe you tought about it already:
onlyReloadable = Boolean.parseBoolean(parseOptionKey));
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java
Line 62: "", getHelperByType(type), reloadable);
can inline the call to ConfigurationAt here and remove the variable 'reloadable'
Line 68: return new ConfigKey(keyType, "", "", keyName, "", null, "",
getHelperByType(keyType), reloadable);
?
--
To view, visit http://gerrit.ovirt.org/4390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57b48d82682223d92f0e2a4108353a861f22ddc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
