Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Do not enable NFS on upgrade ......................................................................
Patch Set 2: > because you override this environment variable based on upgrade without > allowing user to override you. Sorry, now I understand. Do we really want to add an endless amount of code for whatever potential needs? Will this work if user sets in a conf file with '[environment:override]'? I think so. -- To view, visit http://gerrit.ovirt.org/26043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10734f3debd5e3fb122707deb0cb8b354fbe2fa6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
