Daniel Erez has posted comments on this change.

Change subject: engine: Set default tpgt value to 1
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/26050/3/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java:

Line 393:                                                           
"StorageServerConnection.user_name",
Line 394:                                                           
"StorageServerConnection.password" },
Line 395:                                            new Object[] { GUIDS[0],
Line 396:                                                           
ISCSI_SERVER_ADDRESS,
Line 397:                                                           "1", 
//TODO: right now hard-coded, but this should change when VDSM and Backend 
support portal
can the constant be reused here?
Line 398:                                                           ISCSI_IQN,
Line 399:                                                           
ISCSI_PORT_STRING,
Line 400:                                                           
ISCSI_STORAGE_TYPE,
Line 401:                                                           
ISCSI_USER_NAME,


-- 
To view, visit http://gerrit.ovirt.org/26050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ebfc1335b051e02f62b9544d2500416818940d0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to