Juan Hernandez has posted comments on this change. Change subject: core: Enable log-in for a regular user via cloud-init ......................................................................
Patch Set 2: (2 comments) Is there any possibility that we may want to add more than one user in the future? If so we should model the user/password as a list. http://gerrit.ovirt.org/#/c/26011/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 2563: <xs:element name="input_locale" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2564: <xs:element name="ui_language" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2565: <xs:element name="system_locale" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2566: <xs:element name="user_locale" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2567: <xs:element name="user_name" type="xs:string" minOccurs="0" maxOccurs="1"/> Is this the name of the "root" user? I mean, does the "root_password" belong to this "user_name", or are they completely unrelated? Line 2568: </xs:sequence> Line 2569: </xs:complexType> Line 2570: Line 2571: <xs:element name="dns" type="DNS"/> http://gerrit.ovirt.org/#/c/26011/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java: Line 1258: } Line 1259: Line 1260: if (model.isSetUsers()) { Line 1261: for (User user : model.getUsers().getUsers()) { Line 1262: // currently only root password supported in backend If we are adding a userName element field to VmInit then we should here copy the value given by the user into that field, otherwise when using Cloud-Init we won't use "root" as the user, but the default. That would break backwards compatibility. Line 1263: if ("root".equals(user.getUserName())) { Line 1264: entity.setRootPassword(user.getPassword()); Line 1265: } Line 1266: } -- To view, visit http://gerrit.ovirt.org/26011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebfe44ec68e8bcfae5087504bf5cd29b29aad49b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
