Kobi Ianko has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/23702/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestNumaNode.java: Line 15: private Guid id; Line 16: Line 17: private Guid vmGuid; Line 18: Line 19: private Integer index; Do you want to use Class Integer, Long and not primitives? Is null a possible value? Line 20: Line 21: private String vcpu_ids; Line 22: Line 23: private int vcpu_count; Line 126: } else if (!vmGuid.equals(other.vmGuid)) Line 127: return false; Line 128: return true; Line 129: } Line 130: a toString() method would be nice http://gerrit.ovirt.org/#/c/23702/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaTuneMode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaTuneMode.java: Line 5: Line 6: public enum NumaTuneMode { Line 7: Strict, Line 8: Interleave, Line 9: Preferred; consider upper case Line 10: Line 11: Line 12: private String value; Line 13: private static Map<String, NumaTuneMode> mappings; -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
