Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: read legacy config with trivial parser ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26024/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py: Line 67: Line 68: def __init__(self, context): Line 69: super(Plugin, self).__init__(context=context) Line 70: Line 71: def _parse_legacy_conf(self, filename): > No special reason, just copied mostly as-is the 3.3 behavior to ensure comp please do not copy code from 3.3, do this properly. Line 72: result = {} Line 73: with open(filename) as f: Line 74: for line in f.read().splitlines(): Line 75: matches = self._RE_LEGACY_CONF.match(line) -- To view, visit http://gerrit.ovirt.org/26024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563e8dcfa54e6d23c1e4828c422dcf88ffe1738e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
