Arik Hadas has posted comments on this change. Change subject: core: fetch only the dynamic part of the vm in MigrateVDSCommand ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25602/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java: Line 39: if (vdsReturnValue.getSucceeded()) { Line 40: vmDynamic.setStatus(VMStatus.MigratingFrom); Line 41: vmDynamic.setMigratingToVds(getParameters().getDstVdsId()); Line 42: vmDynamic.setExitStatus(VmExitStatus.Normal); Line 43: vmDynamic.setExitMessage(StringUtils.EMPTY); > i prefer calling InternalSetVmStatus and not copy its logic here me too, that's the downside of this change but I didn't want to keep fetching VmStatic as well just because of that. Line 44: ResourceManager.getInstance().AddAsyncRunningVm(getParameters().getVmId()); Line 45: getVDSReturnValue().setReturnValue(VMStatus.MigratingFrom); Line 46: } else { Line 47: log.error("Failed Vm migration"); -- To view, visit http://gerrit.ovirt.org/25602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55b4365d9a71a47b4a72f98bae649a363f43ef03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
