Mike Kolesnik has posted comments on this change. Change subject: webadmin: Extract external subnet model & widget ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25358/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java: Line 179: Line 180: Frontend.getInstance().runMultipleAction(VdcActionType.AttachNetworkToVdsGroup, actionParameters1); Line 181: Line 182: if ((Boolean) getExport().getEntity() Line 183: && getSubnetModel().getName().getEntity() != null > Done Actually this requires another BZ as it's not related to this change which just touched this part due to refactoring. The change is not very simple on oVirt side and requires various adjustments which I prefer that be tracked separately from these changes which are about additional functionality. Line 184: && !getSubnetModel().getName().getEntity().isEmpty()) { Line 185: getSubnetModel().setExternalNetwork(getNetwork().getProvidedBy()); Line 186: getSubnetModel().flush(); Line 187: -- To view, visit http://gerrit.ovirt.org/25358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9c34a1ceb8c92e8ff813301186a2f5c9f499b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
