Yair Zaslavsky has posted comments on this change.

Change subject: core: [CpuPinning] db support for cpu_pinning
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/03_01_1110_add_cpu_pinning.sql
Line 2: select fn_db_add_column('vm_static', 'cpu_pinning', 'varchar(4000) 
default null');
Where does the limitation of 4000 come from?
Maybe this should be created as text and not as a varchar with limitation?

--
To view, visit http://gerrit.ovirt.org/4595
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f252a4ab54d6e706aee490e759a766cffd69e61
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to