Moti Asayag has posted comments on this change.

Change subject: engine: event should contain the iface which exceeded defined 
threshold
......................................................................


Patch Set 8:

Mooli,

According to AuditLogRowMapper, entries read from the audit-log table are being 
converted into AuditLog entity:

entity.setlog_type(AuditLogType.forValue(rs.getInt("log_type")));

If we remove the deprecated entry from AuditLogType we might face a null value 
returned there and a surprise in the former of NPE when unexpected.

A clean-up for that enum should be done for a lot of deprecated entries, out of 
the scope of this patch.

-- 
To view, visit http://gerrit.ovirt.org/25609
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22b3510398ac6fa3acf93fcb596dd6ea10b26366
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to