Tal Nisan has posted comments on this change. Change subject: webadmin: Filter domains on disk move dialog from main disk tab ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25777/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java: Line 109: params.add(new IdQueryParameters(disk.getId())); Line 110: } Line 111: Line 112: if (getActionType() == VdcActionType.MoveDisks) { Line 113: Frontend.getInstance().runMultipleQueries(queries, params, new IFrontendMultipleQueryAsyncCallback() { > we usually try to avoid runMultipleQueries as much as possible - performanc It will require a new query, this solution works ok since you choose mostly a small amount of disks for move operation, I suggest we'll merge it like this for the version and work on a performance fix with the new query Line 114: @Override Line 115: public void executed(FrontendMultipleQueryAsyncResult result) { Line 116: for (int i = 0; i < result.getReturnValues().size(); i++) { Line 117: Map<Boolean, List<VM>> resultValue = result.getReturnValues().get(i).getReturnValue(); -- To view, visit http://gerrit.ovirt.org/25777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia28d3acd7ceeaff07745f16af920f8d225e485c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
