Moti Asayag has posted comments on this change. Change subject: <core>: use 'this' to get 'this'. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25941/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-14 13:48:21 +0100 Line 4: Commit: Martin Mucha <mmu...@redhat.com> Line 5: CommitDate: 2014-03-14 13:48:21 +0100 Line 6: Line 7: <core>: use 'this' to get 'this'. angle brackets can be spared. Line 8: Line 9: Change-Id: Ib7ceb490af9b11646bf0c5f9d47768acf41fc293 Line 10: Bug-Url: https://bugzilla.redhat.com/1063064 http://gerrit.ovirt.org/#/c/25941/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java: Line 347: public List<String> allocateMacAddresses(int numberOfAddresses) { Line 348: List<String> macAddresses = new ArrayList<String>(numberOfAddresses); Line 349: Line 350: for (int i = 0; i < numberOfAddresses; ++i) { Line 351: macAddresses.add(this.allocateNewMac()); i guess "this." can be omitted completely ? Line 352: } Line 353: Collections.sort(macAddresses); Line 354: Line 355: return macAddresses; -- To view, visit http://gerrit.ovirt.org/25941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ceb490af9b11646bf0c5f9d47768acf41fc293 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
