Sandro Bonazzola has posted comments on this change. Change subject: Update the services to use the new storage backend classes ......................................................................
Patch Set 15: Code-Review+1 (2 comments) Just minor comments that can be safely ignored. http://gerrit.ovirt.org/#/c/25800/15/ovirt_hosted_engine_ha/broker/listener.py File ovirt_hosted_engine_ha/broker/listener.py: Line 234: On failure, a RequestError exception is raised (often by dispatchees). Line 235: """ Line 236: tokens = shlex.split(data) Line 237: type = tokens.pop(0) Line 238: self._log.debug("Request type %s from %s", type, client) why not using format? Line 239: Line 240: # TODO fix to be less procedural, e.g. dict of req_type=handler_func() Line 241: if type == 'monitor': Line 242: # Start a submonitor and add its id to the list at this http://gerrit.ovirt.org/#/c/25800/15/ovirt_hosted_engine_ha/broker/storage_broker.py File ovirt_hosted_engine_ha/broker/storage_broker.py: Line 83: try: Line 84: path, offset = self._backends[client].filename(service_type) Line 85: self._log.debug("Getting stats for service %s from %s with" Line 86: " offset %d", Line 87: service_type, path, offset) why not using format? Line 88: except KeyError: Line 89: self._log.error("No storage configured for %s", client) Line 90: return {} Line 91: -- To view, visit http://gerrit.ovirt.org/25800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ad1567c53af561e918be69b8f1b33f75b77fc05 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
