Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changing ids of users and groups ......................................................................
Patch Set 5: (2 comments) way too complex for me to review :( +1 for the principal. http://gerrit.ovirt.org/#/c/25966/5/packaging/dbscripts/upgrade/03_05_0150_change_group_ids.sql File packaging/dbscripts/upgrade/03_05_0150_change_group_ids.sql: Line 30: UPDATE tmp_users_groups t SET group_id = ( Line 31: SELECT temp_id FROM ad_groups WHERE id = t.group_id Line 32: ); Line 33: CREATE temp TABLE tmp_users_group_ids AS Line 34: SELECT user_id, array_to_string(array_agg(group_id), ',') group_ids FROM tmp_users_groups GROUP BY user_id; tab? Line 35: UPDATE users u SET group_ids = ( Line 36: SELECT group_ids FROM tmp_users_group_ids WHERE user_id = u.user_id Line 37: ); Line 38: UPDATE ad_groups SET id = temp_id; Line 55: Line 56: Line 57: Line 58: Line 59: why these spaces? -- To view, visit http://gerrit.ovirt.org/25966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a502e9972e76ebe1a2c809ace1e47f6db5c9fdb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
