Yair Zaslavsky has posted comments on this change. Change subject: core: Adding more tests to RpmVersion ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/RpmVersionTest.java Line 26: RpmVersion vdsm1 = new RpmVersion("vdsm-4.9.6-12", "vdsm", true); Done Line 38: assertTrue(ver22.compareTo(ver31) < 0); We would like to move to single "Version" class in the system AFAIK. I will change the CTOR. -- To view, visit http://gerrit.ovirt.org/4748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56d2c351e2db0c9569a6efe7c5674dbb5784a57f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches