Juan Hernandez has posted comments on this change. Change subject: core: Introduce boot time field in VDS ......................................................................
Patch Set 2: (1 comment) The RESTAPI part looks good. However, I would suggest to consider making this additional information part of the "statistics" sub resource, instead of an additional element of the host resource. Dima, take a look at the HostStatisticalQuery class, and how we manage "memory.total", for example. http://gerrit.ovirt.org/#/c/25880/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1514: <xs:element ref="hooks" minOccurs="0"/> Line 1515: <xs:element name="libvirt_version" type="Version" minOccurs="0" maxOccurs="1"/> Line 1516: <!-- Optionally specify the display address of this host explicitly --> Line 1517: <xs:element ref="display" minOccurs="0"/> Line 1518: <xs:element name="boot_time" type="xs:dateTime" minOccurs="0" maxOccurs="1" /> > api changes should be separated from engine core. so juan or oliel will rev Having a separate change for RESTAPI is nice, but it isn't a requirement. If I understand correctly this is a read-only item, so it will never be part of the parameters of a add/update/action, thus it doesn't need to be in rsdl_metadata.yaml. Line 1519: </xs:sequence> Line 1520: </xs:extension> Line 1521: </xs:complexContent> Line 1522: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/25880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec679a4ce5ddfbc1735db380feab69eb3798ae6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
