Eli Mesika has uploaded a new change for review.

Change subject: core: Setting missing severity to audit log...
......................................................................

core: Setting missing severity to audit log...

Setting missing severity to audit log messages

This patches adding settings for audit log severities that were logged
as NORMAL messages instead of ERROR/WARNING

Change-Id: If91293ebf0eb948f1fa1d7d31d4ae1cde9eb11c8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1047889
Signed-off-by: Eli Mesika <emes...@redhat.com>
---
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/25919/1

diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
index f3af148..c7219da 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
@@ -230,7 +230,7 @@
         severities.put(AuditLogType.USER_VDC_LOGOUT, AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.USER_VDC_LOGOUT_FAILED, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.AD_COMPUTER_ACCOUNT_SUCCEEDED, 
AuditLogSeverity.NORMAL);
-        severities.put(AuditLogType.AD_COMPUTER_ACCOUNT_FAILED, 
AuditLogSeverity.NORMAL);
+        severities.put(AuditLogType.AD_COMPUTER_ACCOUNT_FAILED, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.USER_ADD_PERMISSION, 
AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.USER_ADD_PERMISSION_FAILED, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.USER_REMOVE_PERMISSION, 
AuditLogSeverity.NORMAL);
@@ -363,7 +363,7 @@
         severities.put(AuditLogType.VDS_LOW_DISK_SPACE_ERROR, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.VDS_ACTIVATE_ASYNC, 
AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.VDS_ACTIVATE_MANUAL_HA_ASYNC, 
AuditLogSeverity.WARNING);
-        severities.put(AuditLogType.VDS_ACTIVATE_FAILED_ASYNC, 
AuditLogSeverity.NORMAL);
+        severities.put(AuditLogType.VDS_ACTIVATE_FAILED_ASYNC, 
AuditLogSeverity.WARNING);
         
severities.put(AuditLogType.VDS_SET_NON_OPERATIONAL_VM_NETWORK_IS_BRIDGELESS, 
AuditLogSeverity.WARNING);
         
severities.put(AuditLogType.EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER, 
AuditLogSeverity.WARNING);
         severities.put(AuditLogType.VDS_TIME_DRIFT_ALERT, 
AuditLogSeverity.WARNING);
@@ -670,13 +670,13 @@
         severities.put(AuditLogType.USER_FAILED_DETACH_USER_FROM_VM, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.VM_DOWN, AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.USER_CHANGE_FLOPPY_VM, 
AuditLogSeverity.NORMAL);
-        severities.put(AuditLogType.USER_FAILED_CHANGE_FLOPPY_VM, 
AuditLogSeverity.NORMAL);
-        severities.put(AuditLogType.VM_MIGRATION_FAILED_FROM_TO, 
AuditLogSeverity.NORMAL);
+        severities.put(AuditLogType.USER_FAILED_CHANGE_FLOPPY_VM, 
AuditLogSeverity.ERROR);
+        severities.put(AuditLogType.VM_MIGRATION_FAILED_FROM_TO, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.USER_UPDATE_VM_POOL_WITH_VMS, 
AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.USER_LOGGED_IN_VM, 
AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.USER_LOCKED_VM, AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.USER_UNLOCKED_VM, AuditLogSeverity.NORMAL);
-        severities.put(AuditLogType.VM_MIGRATION_ON_CONNECT_CHECK_FAILED, 
AuditLogSeverity.NORMAL);
+        severities.put(AuditLogType.VM_MIGRATION_ON_CONNECT_CHECK_FAILED, 
AuditLogSeverity.ERROR);
         severities.put(AuditLogType.VM_MIGRATION_ON_CONNECT_CHECK_SUCCEEDED, 
AuditLogSeverity.NORMAL);
         severities.put(AuditLogType.VM_CLEARED, AuditLogSeverity.NORMAL);
         
severities.put(AuditLogType.CANNOT_HIBERNATE_RUNNING_VMS_AFTER_CLUSTER_CPU_UPGRADE,
 AuditLogSeverity.WARNING);


-- 
To view, visit http://gerrit.ovirt.org/25919
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If91293ebf0eb948f1fa1d7d31d4ae1cde9eb11c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to