Liran Zelkha has posted comments on this change. Change subject: core: consider the event type while printing events to engine.log ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25811/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java: Line 167: Line 168: switch (severity) { Line 169: case NORMAL: Line 170: case ALERT: Line 171: log.info(logMessage); > Right, I agree , Alerts should be warnings Done Line 172: break; Line 173: case ERROR: Line 174: log.error(logMessage); Line 175: break; Line 167: Line 168: switch (severity) { Line 169: case NORMAL: Line 170: case ALERT: Line 171: log.info(logMessage); > wouldn't you recommend treating the alerts as warning when message is being Done Line 172: break; Line 173: case ERROR: Line 174: log.error(logMessage); Line 175: break; -- To view, visit http://gerrit.ovirt.org/25811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e8444fc33aa487d378b7310a1004a016c762c0a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
