Allon Mureinik has uploaded a new change for review. Change subject: core: UnPowerMock GetVmByVmIdQueryTest ......................................................................
core: UnPowerMock GetVmByVmIdQueryTest Removed PowerMock dependecy from GetVmByVmIdQueryTest. Before this patch, the test was not a good unit test - it did not test just the query, but also VmHandler's functionallity, which should have been tested separately. This patch turns the test into a strict unit teset, which only test's the query's functionallity, and this PowerMock is no longer needed. Change-Id: Ieaf73c28f2321e564d9c9d336dbf33a89e7a2929 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmIdQueryTest.java 2 files changed, 10 insertions(+), 40 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/4768/1 -- To view, visit http://gerrit.ovirt.org/4768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieaf73c28f2321e564d9c9d336dbf33a89e7a2929 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
