Tomas Jelinek has posted comments on this change. Change subject: frontend: Enable configuration of Serial Number ......................................................................
Patch Set 9: (2 comments) just small comments http://gerrit.ovirt.org/#/c/25101/9//COMMIT_MSG Commit Message: Line 14: UnitVmModel and ClusterModel. Line 15: Line 16: The SerialNumberPolicyWidget utilizes the existing EnumRadioEditor to Line 17: edit the SerialNumberPolicy. The EnumRadioEditor was moved from webadmin Line 18: to uicommon to be also usable when editing VM's in userportal. to gwt-common :) Line 19: Line 20: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=918138 Line 21: Change-Id: I7064570c2d66fdd473c31214892867b8b9b67a21 http://gerrit.ovirt.org/#/c/25101/9/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml: Line 16: .serialNumberPolicy { Line 17: float: left; Line 18: } Line 19: Line 20: .customSerialNumber { I guess this could be removed Line 21: width: 230px; Line 22: float: right; Line 23: padding-top: 56px; Line 24: margin-right: 9px; -- To view, visit http://gerrit.ovirt.org/25101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7064570c2d66fdd473c31214892867b8b9b67a21 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
