Selvasundaram has posted comments on this change.

Change subject: engine: Add Gluster host
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 161:         } else {
Yes. I added cluster.supportGlusterService() check before doing gluster peer 
probe.

Now  doing peer probe only on non vds installation mode.

Line 313:             
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_GLUSTER_HOST_IS_UP);
Done

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 730: ACTION_TYPE_FAILED_NO_GLUSTER_HOST_IS_UP=Cannot ${action} ${type}. 
Cannot add gluster host, No gluster host is up.
Done

--
To view, visit http://gerrit.ovirt.org/4736
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9a7f36a1b54d0c62297afcdd422938d59ad0997
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to