Martin Sivák has posted comments on this change. Change subject: Encapsulate the storage metadata and add support for blockSD ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/25797/3/ovirt_hosted_engine_ha/lib/Makefile.am File ovirt_hosted_engine_ha/lib/Makefile.am: Line 32: log_filter.py \ Line 33: metadata.py \ Line 34: util.py \ Line 35: vds_client.py \ Line 36: storage_backends.py \ > nit: would be nice to keep these sorted Done Line 37: storage_backends_test.py \ Line 38: $(NULL) Line 39: Line 40: SUBDIRS = \ http://gerrit.ovirt.org/#/c/25797/3/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 19: """ Line 20: Line 21: def __init__(self): Line 22: # the atomic block size of the underlying storage Line 23: self._blocksize = 512 > same as constant METADATA_BLOCK_BYTES Not really. This is supposed to be the block size of the underlying storage which can be different for nfs/iscsi/lvm.... For the default I might use the constant though. Line 24: Line 25: def connect(self): Line 26: """Initialize the storage.""" Line 27: raise NotImplementedError() -- To view, visit http://gerrit.ovirt.org/25797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaced4ac08936fc9314ff821343ce33d29a5897cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
